[Mlir-commits] [mlir] [mlir][emitc] Fix form-expressions inside expression (PR #86081)

[Marius Brehler]

marbre wrote:

> Make form-expressions not create `emitc.expression`s for operations inside the `emitc.expression`s, since they are invalid.
> 
> --
> 
> I've discovered it when I wanted to run this pass after some other transformation I perform, so I don't have to re-implement it inside my own pass, however given that I have `emitc.expression` inside the input, it was producing invalid IR.
> 
> Not sure whether it's the right way to fix it.

Before commiting on your behalf, are you okay with using everything above `--` for the commit message? GitHub proposes to use the entire PR description as squash commit message but I assume the first sentence is the better fit here.

https://github.com/llvm/llvm-project/pull/86081