[Mlir-commits] [mlir] [mlir][vector] Update `castAwayContractionLeadingOneDim` to omit transposes solely on leading unit dims. (PR #85694)

[Andrzej Warzyński]

================
@@ -166,6 +166,28 @@ func.func @cast_away_contraction_leading_one_dims_nonleadingunitdim_rank4_acctra
 
 // -----
 
+// CHECK-DAG: #[[$MAP_0:.+]] = affine_map<(d0, d1, d2) -> (d0, d2)>
+// CHECK-DAG: #[[$MAP_1:.+]] = affine_map<(d0, d1, d2) -> (d0, d1, d2)>
+// CHECK-DAG: #[[$MAP_2:.+]] = affine_map<(d0, d1, d2) -> (d1)>
+
+// CHECK-LABEL:   func.func @cast_away_contraction_leading_one_dims_vec_mat(
----------------
banach-space wrote:

Could you name this function to capture what's being tested? Basically, it's a negative test - the pattern is not applied. So, I'd expect to see some `CHECK-NOT` and some hint _why_ the pattern doesn't apply.

Also, could you use more descriptive LIT variable names? You can check other tests in this file in search for inspiration :)

https://github.com/llvm/llvm-project/pull/85694