[Mlir-commits] [mlir] [mlir][spirv] Add folding for SelectOp (PR #85430)

Jakub Kuderski llvmlistbot at llvm.org
Tue Mar 19 11:36:26 PDT 2024


================
@@ -872,7 +846,7 @@ OpFoldResult spirv::SelectOp::fold(FoldAdaptor adaptor) {
 
   // Note: getScalarOrSplatBoolAttr will always return a boolAttr if we are in
   // the scalar case. Hence, we are only required to consider the case of
-  // ElementsAttr in foldSelectOp.
+  // DenseElementsAttr in foldSelectOp.
   return foldSelectOp(operands);
----------------
kuhar wrote:

Now that the logic is much simpler, I'd inline `foldSelectOp` here.

https://github.com/llvm/llvm-project/pull/85430


More information about the Mlir-commits mailing list