[Mlir-commits] [mlir] [vscode-mlir] Added per-LSP-server executable arguments (PR #79671)
River Riddle
llvmlistbot at llvm.org
Mon Mar 18 17:41:40 PDT 2024
================
@@ -179,14 +179,19 @@ export class MLIRContext implements vscode.Disposable {
// Initialize additional configurations for this server.
if (languageName === 'pdll') {
+ additionalServerArgs = config.get<string[]>("pdll_additional_server_args", null, []);
await this.preparePDLLServerOptions(workspaceFolder, configsToWatch,
filepathsToWatch,
additionalServerArgs);
} else if (languageName == 'tablegen') {
+ additionalServerArgs = config.get<string[]>("table_additional_server_args", null, []);
----------------
River707 wrote:
Can you just pull out the additional argument initialization to the set definition and generalize with `languageName + "_additional_server_args"`
https://github.com/llvm/llvm-project/pull/79671
More information about the Mlir-commits
mailing list