[Mlir-commits] [mlir] [mlir] Declare promised interfaces for all dialects (PR #78368)

Mehdi Amini llvmlistbot at llvm.org
Mon Mar 18 11:43:05 PDT 2024


joker-eph wrote:

> That's not what mlir/lib/Dialect/Bufferization/IR/BufferizableOpInterface.cpp does, it dyn_casts first and OpFilters second. Should that be fixed?

I would say tentatively yes based on what I understand OpFiltef to be about, but let’s ask @matthias-springer about the intended behavior for OpFilter?

> I don't consider those header-only dependencies, and there are build modes where this will break. 

I am interested to understand this more: what are these build modes? And why aren’t these « header-only » to you? (IIRC we crafted all this around inline functions) 

https://github.com/llvm/llvm-project/pull/78368


More information about the Mlir-commits mailing list