[Mlir-commits] [mlir] fix a concurrent destruction issue for FallbackTypeIDResolver::registerImplicitTypeID due to function static variable (PR #85471)

[Stella Laurenzo]

stellaraccident wrote:

> > I don't think this warrants a change. From what I see, it is arbitrary that the wrong application shutdown sequence happens to be doing something that needs to access this static. It could have just as easily been attempting to access a destructed cl flag, etc. The bug appears to be in the application.
> 
> Yeah I think you are right; I look a deeper look at the offending unit tests; seems that there are unjoined futures; thus leaving them running the function when the program is existing. I will probably close this PR soon.
> 
> Thanks!

No worries. It is easy to see a smoking gun like that from a sanitizer and jump to a conclusion that makes it go away. Figured it was something like what you found.

https://github.com/llvm/llvm-project/pull/85471