[Mlir-commits] [mlir] [mlir][math] Fix casting mistake in tanh expansion and test (PR #85364)

Maksim Levental llvmlistbot at llvm.org
Fri Mar 15 09:38:25 PDT 2024


makslevental wrote:

> Any suggestions? Should i just revert my original merge until this is sorted?

General operating procedure is to get build bots back to green ASAP, i.e., revert or "fix forward". Technically this didn't break build bots I guess but same good faith interpretation applies (since you believe this is a breaking change). I can't approve because I can't manage to unwind right now all of bit patterns so yea revert (but obv don't abandon this one...).

https://github.com/llvm/llvm-project/pull/85364


More information about the Mlir-commits mailing list