[Mlir-commits] [llvm] [mlir] [mlir] Move InlinerInterface from Transforms to Interfaces. (PR #84878)

[Christian Sigg]

chsigg wrote:

Yes, consuming the header file under `srcs` is better than re-exporting it under `hdrs`. That's worse than an incomplete (just exporting the header) `cc_library` target, because it requires [exporting](https://github.com/llvm/llvm-project/blob/01a31cee561efe90fbd1d33fa89f403dd8ff9012/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel#L12422) the plain header file for downstream projects, see also the TensorFlow link above.

We don't need any of those crutches in this particular case though, we can make a target that exposes and implements the `DialectInlinerInterface`. I will go ahead with this and create a separate PR (approach 1. above). If you would like me to also move any interface definitions into separate files, please let me know.

https://github.com/llvm/llvm-project/pull/84878