[Mlir-commits] [llvm] [mlir] [ADT] Add signed and unsigned mulh to APInt (PR #84719)
Simon Pilgrim
llvmlistbot at llvm.org
Thu Mar 14 08:28:16 PDT 2024
================
@@ -434,9 +434,7 @@ arith::MulSIExtendedOp::fold(FoldAdaptor adaptor,
// Invoke the constant fold helper again to calculate the 'high' result.
Attribute highAttr = constFoldBinaryOp<IntegerAttr>(
adaptor.getOperands(), [](const APInt &a, const APInt &b) {
----------------
RKSimon wrote:
I'd recommend any further refactor changes like that as followups for somebody (not necessarily @Atousa) - to ensure the changes in this PR are just the move to the APIntOps::mulh* helpers.
https://github.com/llvm/llvm-project/pull/84719
More information about the Mlir-commits
mailing list