[Mlir-commits] [mlir] [mlir] Declare promised interfaces for all dialects (PR #78368)

Oleksandr Alex Zinenko llvmlistbot at llvm.org
Thu Mar 14 02:48:36 PDT 2024


================
@@ -8,8 +8,11 @@
 
 #include "mlir/Dialect/Affine/IR/AffineOps.h"
 #include "mlir/Dialect/Arith/IR/Arith.h"
+#include "mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h"
 #include "mlir/Dialect/Complex/IR/Complex.h"
 #include "mlir/Dialect/Tensor/IR/Tensor.h"
+#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
----------------
ftynse wrote:

I see a semi-satisfactory solution: isolate transform dialect interfaces into a separate library that does not depend on the dialect definition itself. Tensor dialect can then depend/include from that, and so can other dialects, without additional cost. Eventually, that interface library can move under `lib/Interfaces` as it will follow exactly the same model. (There is an adjacent discussion on `lib/Interfaces`, but I don't want to block progress here on that).

https://github.com/llvm/llvm-project/pull/78368


More information about the Mlir-commits mailing list