[Mlir-commits] [mlir] [MLIR] EmitC: Add subscript operator (PR #84783)

[Simon Camphausen]

https://github.com/simon-camp requested changes to this pull request.

Overall looks good to me.

I don't really like that we are accumulating more and more special cases in the emitter. With `emitc.literal`, `emitc.expression` and `emitc.subscript` we now have three ops for which the text emission is deferred in one way or another. I think we can refactor this in a follow up though.

https://github.com/llvm/llvm-project/pull/84783