[Mlir-commits] [mlir] [mlir][math] Implement alternative decomposition for tanh (PR #85025)
Kai Sasaki
llvmlistbot at llvm.org
Thu Mar 14 00:41:05 PDT 2024
https://github.com/Lewuathe approved this pull request.
It looks good to me. We may want to have the correctness check running in CPU runner if possible. I think it would be possible to write down something like this case for `math.ctlz`.
https://github.com/llvm/llvm-project/blob/main/mlir/test/Integration/Dialect/Math/CPU/mathtofuncs_ctlz.mlir
https://github.com/llvm/llvm-project/pull/85025
More information about the Mlir-commits
mailing list