[Mlir-commits] [mlir] [mlir] Declare promised interfaces for all dialects (PR #78368)

Mehdi Amini llvmlistbot at llvm.org
Wed Mar 13 22:48:42 PDT 2024


================
@@ -63,6 +64,9 @@ void mlir::bufferization::BufferizationDialect::initialize() {
 #include "mlir/Dialect/Bufferization/IR/BufferizationOps.cpp.inc"
       >();
   addInterfaces<BufferizationInlinerInterface>();
+  declarePromisedInterface<func::CallOp, BufferizableOpInterface>();
+  declarePromisedInterface<func::FuncOp, BufferizableOpInterface>();
+  declarePromisedInterface<func::ReturnOp, BufferizableOpInterface>();
----------------
joker-eph wrote:

No I think we should be uniform here: the FuncDialect isn't more special than any other, and you defined the promise for all dialect in their own initializer. This is the only exception right now.

https://github.com/llvm/llvm-project/pull/78368


More information about the Mlir-commits mailing list