[Mlir-commits] [mlir] 6095f8b - Get rid of noisy debug log in verifyOpAndAdjustFlags. (#84677)

[llvmlistbot at llvm.org]

Author: Justin Lebar
Date: 2024-03-12T12:52:31-07:00
New Revision: 6095f8bbc410d2f8b926a32ba969d507f7343949

URL: https://github.com/llvm/llvm-project/commit/6095f8bbc410d2f8b926a32ba969d507f7343949
DIFF: https://github.com/llvm/llvm-project/commit/6095f8bbc410d2f8b926a32ba969d507f7343949.diff

LOG: Get rid of noisy debug log in verifyOpAndAdjustFlags. (#84677)

This debug log adds noise to a large fraction of *other* debug logs when
you run with -debug, because it prints "Verifying operation: blah blah\n"
whenever those other debug logs dump an op.

You can use -debug-only to get around this, but sometimes -debug really
is what's called for!

Added: 
    

Modified: 
    mlir/lib/IR/AsmPrinter.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/IR/AsmPrinter.cpp b/mlir/lib/IR/AsmPrinter.cpp
index 8d75349f8eed45..456cf6a2c27783 100644
--- a/mlir/lib/IR/AsmPrinter.cpp
+++ b/mlir/lib/IR/AsmPrinter.cpp
@@ -1895,9 +1895,6 @@ static OpPrintingFlags verifyOpAndAdjustFlags(Operation *op,
       printerFlags.shouldAssumeVerified())
     return printerFlags;
 
-  LLVM_DEBUG(llvm::dbgs() << DEBUG_TYPE << ": Verifying operation: "
-                          << op->getName() << "\n");
-
   // Ignore errors emitted by the verifier. We check the thread id to avoid
   // consuming other threads' errors.
   auto parentThreadId = llvm::get_threadid();