[Mlir-commits] [mlir] [mlir] Make the split markers of splitAndProcessBuffer configurable. (PR #84765)

Ingo Müller llvmlistbot at llvm.org
Tue Mar 12 06:24:41 PDT 2024


================
@@ -1621,7 +1622,8 @@ PDLTextFile::getPDLLViewOutput(lsp::PDLLViewOutputKind kind) {
         [&](PDLTextFileChunk &chunk) {
           chunk.document.getPDLLViewOutput(outputOS, kind);
         },
-        [&] { outputOS << "\n// -----\n\n"; });
----------------
ingomueller-net wrote:

Note that I am not sure whether this and the other occurrence of the constant in the same file below *have* to be the same as in `mlir-opt` and `mlir-translate` or whether it this constant is local to the PDLL server. In the latter case, it might be better not to use the constant from `ToolUtilities.h`. What do you think?

https://github.com/llvm/llvm-project/pull/84765


More information about the Mlir-commits mailing list