[Mlir-commits] [llvm] [mlir] [mlir] Move InlinerInterface from Transforms to Interfaces. (PR #84878)

[Christian Sigg]

chsigg wrote:

> to me the Interfaces folder is meant I believe to host the interfaces that aren't tied to specific transforms, instead they were meant for the common traits of the IR, basically what is needed during ODS generation or what describes the IR more generically than what's tied to a specific transform (like control-flow interface).

I see your point from the perspective of transform-specific interfaces. If you looked at it from a dialect perspective, which currently needs to depend on stuff from transform, the change suggested here might be easier to motivate.

That said, I'm happy to get guidance about what makes the most sense. I primarily see all the bazel targets that export the InliningUtils.h header, sticking out like sore thumbs.

https://github.com/llvm/llvm-project/pull/84878