[Mlir-commits] [llvm] [mlir] [mlir] Move InlinerInterface from Transforms to Interfaces. (PR #84878)

Mehdi Amini llvmlistbot at llvm.org
Mon Mar 11 23:56:47 PDT 2024


joker-eph wrote:

I don't see this layout as historical actually: to me the Interfaces folder is meant I believe to host the interfaces that aren't tied to specific transforms, instead they were meant for the common traits of the IR, basically what is needed during ODS generation or what describes the IR more generically than what's tied to a specific transform (like control-flow interface). 

Looking at the list right now, there are a quite a few interfaces which don't belong here and are instead directly attached to a specific transform: to me they don't belong here.

@Mogball, @jpienaar, and @ftynse for the layering discussion here.

https://github.com/llvm/llvm-project/pull/84878


More information about the Mlir-commits mailing list