[Mlir-commits] [mlir] [mlir][tosa] Rename Tosa Div op to IntDiv Op (PR #80047)

Tai Ly llvmlistbot at llvm.org
Mon Mar 11 14:00:18 PDT 2024


https://github.com/Tai78641 commented:



> *[Reviewable](https://reviewable.io/reviews/llvm/llvm-project/80047)* status: 0 of 10 files reviewed, 2 unresolved discussions (waiting on @jpienaar)

___
*[`mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp` line 95 at r1](https://reviewable.io/reviews/llvm/llvm-project/80047#-Ns3bD4nBZLcfmbuuFTe:-NsjJ6X_7Z-rJPOamlsT:b-896fix) ([raw file](https://github.com/llvm/llvm-project/blob/1513939fcbf02b1b080185e8cdc460348f8516f6/mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp#L95)):*
<details><summary><i>Previously, jpienaar (Jacques Pienaar) wrote…</i></summary><blockquote>

Prefer the other form (https://mlir.llvm.org/deprecation/)
</blockquote></details>

Done.
___
*[`mlir/lib/Dialect/Tosa/IR/TosaOps.cpp` line 1333 at r1](https://reviewable.io/reviews/llvm/llvm-project/80047#-Ns3bM9qBSHKS3qWSX0P:-NsjJ58r8i2hJ6vXFk69:b-896fix) ([raw file](https://github.com/llvm/llvm-project/blob/1513939fcbf02b1b080185e8cdc460348f8516f6/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp#L1333)):*
<details><summary><i>Previously, jpienaar (Jacques Pienaar) wrote…</i></summary><blockquote>

I think these were sorted, could you keep it such?
</blockquote></details>

Done.


<!-- Sent from Reviewable.io -->


https://github.com/llvm/llvm-project/pull/80047


More information about the Mlir-commits mailing list