[Mlir-commits] [mlir] [MLIR] Add missing MLIRGPUDialect dep to MLIRSPIRVDialect (PR #84554)

[Thomas Preud'homme]

RoboTux wrote:

> > What does the failure look like? `ninja clean && ninja lib/libMLIRSPIRVDialect.a` does not reproduce at HEAD for me right now.
> 
> I can reproduce this using `ninja clean && rm .ninja_deps && ninja lib/libMLIRSPIRVDialect.a`. One needs to delete `.ninja_deps` as it contains/records header dependencies found by the C++ compiler on successful compiles. Unless you have a fresh cmake generation directory then ninja likely already recorded the dependency.

Ah that's it, I forgot that bash's * doesn't match files starting with a dot. Removing the .ninja_deps I can now reproduce again. I've updated the description again accordingly. Thanks!

https://github.com/llvm/llvm-project/pull/84554