[Mlir-commits] [llvm] [mlir] Add llvm::min/max_element and use it in llvm/ and mlir/ directories. (PR #84678)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Sun Mar 10 08:07:09 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 3ec1f25f3cf9346590892397ec9ddd859397d363 d853655c80f7643c91d748407eed4692bfdcb0cf -- llvm/include/llvm/ADT/STLExtras.h llvm/include/llvm/CodeGen/RegAllocPBQP.h llvm/lib/Analysis/ScalarEvolution.cpp llvm/lib/DebugInfo/PDB/Native/PDBFile.cpp llvm/lib/IR/DataLayout.cpp llvm/lib/ObjCopy/MachO/MachOWriter.cpp llvm/lib/ProfileData/GCOV.cpp llvm/lib/Target/AArch64/SVEIntrinsicOpts.cpp llvm/lib/Target/AMDGPU/GCNILPSched.cpp llvm/lib/Target/AMDGPU/SIFixSGPRCopies.cpp llvm/lib/Target/AMDGPU/SIMachineScheduler.cpp llvm/lib/Target/Hexagon/HexagonCommonGEP.cpp llvm/lib/Target/Hexagon/HexagonConstExtenders.cpp llvm/lib/Target/Hexagon/HexagonGenInsert.cpp llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp llvm/lib/Transforms/Scalar/GVNSink.cpp llvm/lib/Transforms/Scalar/JumpThreading.cpp llvm/lib/Transforms/Scalar/LoopLoadElimination.cpp llvm/lib/Transforms/Utils/SimplifyCFG.cpp llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp llvm/tools/llvm-exegesis/lib/LatencyBenchmarkRunner.cpp llvm/tools/llvm-mca/Views/BottleneckAnalysis.cpp llvm/tools/llvm-mca/Views/SchedulerStatistics.cpp llvm/tools/llvm-pdbutil/DumpOutputStyle.cpp llvm/tools/llvm-pdbutil/MinimalTypeDumper.cpp llvm/tools/llvm-rc/ResourceFileWriter.cpp llvm/utils/FileCheck/FileCheck.cpp llvm/utils/TableGen/CodeGenSchedule.cpp llvm/utils/TableGen/RegisterInfoEmitter.cpp mlir/examples/toy/Ch5/mlir/LowerToAffineLoops.cpp mlir/examples/toy/Ch6/mlir/LowerToAffineLoops.cpp mlir/examples/toy/Ch7/mlir/LowerToAffineLoops.cpp mlir/lib/Conversion/PDLToPDLInterp/PredicateTree.cpp mlir/lib/Dialect/Affine/IR/AffineOps.cpp mlir/lib/Dialect/Affine/Utils/LoopUtils.cpp mlir/lib/Dialect/GPU/TransformOps/GPUTransformOps.cpp mlir/lib/Dialect/Linalg/Transforms/ConvertToDestinationStyle.cpp mlir/lib/Dialect/SPIRV/Transforms/UnifyAliasedResourcePass.cpp mlir/lib/Dialect/Tensor/Transforms/BufferizableOpInterfaceImpl.cpp mlir/lib/IR/AffineMap.cpp mlir/lib/Reducer/ReductionNode.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/include/llvm/CodeGen/RegAllocPBQP.h b/llvm/include/llvm/CodeGen/RegAllocPBQP.h
index 2f059453bf..234f1c6ff1 100644
--- a/llvm/include/llvm/CodeGen/RegAllocPBQP.h
+++ b/llvm/include/llvm/CodeGen/RegAllocPBQP.h
@@ -462,8 +462,8 @@ private:
         NodeStack.push_back(NId);
         G.disconnectAllNeighborsFromNode(NId);
       } else if (!NotProvablyAllocatableNodes.empty()) {
-        NodeSet::iterator NItr =
-            llvm::min_element(NotProvablyAllocatableNodes, SpillCostComparator(G));
+        NodeSet::iterator NItr = llvm::min_element(NotProvablyAllocatableNodes,
+                                                   SpillCostComparator(G));
         NodeId NId = *NItr;
         NotProvablyAllocatableNodes.erase(NItr);
         NodeStack.push_back(NId);

``````````

</details>


https://github.com/llvm/llvm-project/pull/84678


More information about the Mlir-commits mailing list