[Mlir-commits] [mlir] [mlir] tentative fix for "'GTEST_NO_LLVM_SUPPORT' is not defined" war… (PR #84539)

[Peiming Liu]

PeimingLiu wrote:

> the question that I am not able to answer is what is the right default value?

Me neither, I used 0 because it seems to be the default value used by (my local) compiler when the macro is not defined.

> Doesn't this mean that the same value should be used for all of LLVM?

I am not sure about this either, the only subproject I can find which sets the value explicitly is https://github.com/llvm/llvm-project/blob/70da9155efb3aeb2c6b37678168cf29f91e80734/compiler-rt/CMakeLists.txt#L659 (and it uses value 1).


https://github.com/llvm/llvm-project/pull/84539