[Mlir-commits] [flang] [mlir] [Flang][MLIR][OpenMP] Allow setting OMP_MAP_PTR_AND_OBJ by frontends (PR #84328)

[Slava Zakharin]

vzakhari wrote:

Thank you for the changes!

You may ignore this, but I think his low-level naming coming from libomptarget implementation looks off for a higher level dialect.  As I understand, you need to distinguish the pointer and non-pointer members of the aggregate so that you can later properly set `PTR_AND_OBJ`.  So can we use something like `is_ptr_member` to make this difference explicit.  It reads better to me from the language point of view, at least for C/C++.  It also looks okay for Fortran, if we assume the underlying memory representation of the descriptor (which, I believe, will be the only parent whose members can have `is_ptr_member`).

Feel free to go with `PTR_AND_OBJ` though :)

https://github.com/llvm/llvm-project/pull/84328