[Mlir-commits] [mlir] [MLIR] Add llvm (debug) attributes to CAPI (PR #83992)

Oleksandr Alex Zinenko llvmlistbot at llvm.org
Wed Mar 6 01:35:57 PST 2024


================
@@ -7,9 +7,18 @@
 //===----------------------------------------------------------------------===//
 
 #include "mlir-c/Dialect/LLVM.h"
+#include "mlir-c/IR.h"
+#include "mlir-c/Support.h"
 #include "mlir/CAPI/Registration.h"
+#include "mlir/CAPI/Wrap.h"
+#include "mlir/Dialect/LLVMIR/LLVMAttrs.h"
 #include "mlir/Dialect/LLVMIR/LLVMDialect.h"
+#include "mlir/Dialect/LLVMIR/LLVMOpsAttrDefs.h.inc"
----------------
ftynse wrote:

We shouldn't ever need to explicitly include the `.inc` files. I suspect your editor adds includes automatically, which isn't something that we necessarily want in MLIR/LLVM codebase. Transitive includes and forward declarations are totally fine.

https://github.com/llvm/llvm-project/pull/83992


More information about the Mlir-commits mailing list