[Mlir-commits] [mlir] 0e5bde0 - [mlir] Remove noexcept again from move constructors.

Adrian Kuegel llvmlistbot at llvm.org
Wed Mar 6 01:33:12 PST 2024


Author: Adrian Kuegel
Date: 2024-03-06T09:31:44Z
New Revision: 0e5bde021252f68b378b31fd64a885a8b28aad65

URL: https://github.com/llvm/llvm-project/commit/0e5bde021252f68b378b31fd64a885a8b28aad65
DIFF: https://github.com/llvm/llvm-project/commit/0e5bde021252f68b378b31fd64a885a8b28aad65.diff

LOG: [mlir] Remove noexcept again from move constructors.

LLVM does not have the corresponding ClangTidy check enabled, so we
should not be fixing such findings.

Added: 
    

Modified: 
    mlir/include/mlir/IR/BuiltinAttributeInterfaces.h
    mlir/lib/Bindings/Python/TransformInterpreter.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/IR/BuiltinAttributeInterfaces.h b/mlir/include/mlir/IR/BuiltinAttributeInterfaces.h
index 1507c62e3fe07e..b0b9493c1519f6 100644
--- a/mlir/include/mlir/IR/BuiltinAttributeInterfaces.h
+++ b/mlir/include/mlir/IR/BuiltinAttributeInterfaces.h
@@ -35,7 +35,7 @@ struct ElementsAttrIndexer {
 public:
   ElementsAttrIndexer()
       : ElementsAttrIndexer(/*isContiguous=*/true, /*isSplat=*/true) {}
-  ElementsAttrIndexer(ElementsAttrIndexer &&rhs) noexcept
+  ElementsAttrIndexer(ElementsAttrIndexer &&rhs)
       : isContiguous(rhs.isContiguous), isSplat(rhs.isSplat) {
     if (isContiguous)
       conState = rhs.conState;

diff  --git a/mlir/lib/Bindings/Python/TransformInterpreter.cpp b/mlir/lib/Bindings/Python/TransformInterpreter.cpp
index 3530f295ed8218..6517f8c39dfadd 100644
--- a/mlir/lib/Bindings/Python/TransformInterpreter.cpp
+++ b/mlir/lib/Bindings/Python/TransformInterpreter.cpp
@@ -23,7 +23,7 @@ namespace py = pybind11;
 namespace {
 struct PyMlirTransformOptions {
   PyMlirTransformOptions() { options = mlirTransformOptionsCreate(); };
-  PyMlirTransformOptions(PyMlirTransformOptions &&other) noexcept {
+  PyMlirTransformOptions(PyMlirTransformOptions &&other) {
     options = other.options;
     other.options.ptr = nullptr;
   }


        


More information about the Mlir-commits mailing list