[Mlir-commits] [mlir] [mlir][emitc] Fix `emitc.expression` example (PR #84060)

Marius Brehler llvmlistbot at llvm.org
Wed Mar 6 01:20:38 PST 2024


================
@@ -409,9 +409,9 @@ def EmitC_ExpressionOp : EmitC_Op<"expression",
     int32_t v7 = foo(v1 + v2) * (v3 + v4);
     ```
 
-    The operations allowed within expression body are emitc.add, emitc.apply,
-    emitc.call, emitc.cast, emitc.cmp, emitc.div, emitc.mul, emitc.rem and
-    emitc.sub.
+    The operations allowed within expression body are `emitc.add`,
+    `emitc.apply`, `emitc.call`, `emitc.cast`, `emitc.cmp`, `emitc.div`,
----------------
marbre wrote:

It is even more complicated :see_no_evil:  Back in timey we had an `emitc.call` op which was later renamed to `emitc.opaque_call`. After that renaming I introduced a new `emitc.call` op which is more closely resembling `func.func`.

Anyway, thanks for fixing the example in the expression op description which clearly improves the EmitC dialect and lowers the barrier for new users. I appreciate it.

https://github.com/llvm/llvm-project/pull/84060


More information about the Mlir-commits mailing list