[Mlir-commits] [mlir] [mlir][emitc] Fix `emitc.expression` example (PR #84060)
Kirill Chibisov
llvmlistbot at llvm.org
Wed Mar 6 00:37:12 PST 2024
================
@@ -409,9 +409,9 @@ def EmitC_ExpressionOp : EmitC_Op<"expression",
int32_t v7 = foo(v1 + v2) * (v3 + v4);
```
- The operations allowed within expression body are emitc.add, emitc.apply,
- emitc.call, emitc.cast, emitc.cmp, emitc.div, emitc.mul, emitc.rem and
- emitc.sub.
+ The operations allowed within expression body are `emitc.add`,
+ `emitc.apply`, `emitc.call`, `emitc.cast`, `emitc.cmp`, `emitc.div`,
----------------
kchibisov wrote:
>I can add those later today.
yeah, go ahead if you want, I just started learning about mlir/emitc, so it'll take me awhile. Though given that I use emitc directly I'd likely need them.
I just assumed that `call` was valid, but I guess it's a fallout from time when the call wasn't in `emitc` directly.
Anyway, I'll apply suggestion later.
https://github.com/llvm/llvm-project/pull/84060
More information about the Mlir-commits
mailing list