[Mlir-commits] [mlir] [MLIR][LLVM] Support Recursive DITypes (PR #80251)

[Tobias Gysi]

gysit wrote:

> As I was writing recursive support for DICompositeTypeAttr, I realized it's not too difficult to just abstract out the recursive implementation (just in case we missed another DINode that needs recursive support). So with this latest refactor, instead of making DICompositeTypeAttr special, I pulled out the API needed to support recursion into an attr interface: DIRecursiveTypeAttrInterface. This means the importer & exporter can have generic code (targeting any attr that implements this interface), and we won't need to do a major rewrite if we find out about another DINode that needs recursion support.

That looks like a very nice solution indeed!

FYI I have very limited time this week due to business travels. I think I will not get to do a full review before the weekend. 

https://github.com/llvm/llvm-project/pull/80251