[Mlir-commits] [mlir] [MLIR] Add C-API for parsing bytecode (PR #83825)

Matteo Franciolini llvmlistbot at llvm.org
Mon Mar 4 08:13:40 PST 2024


================
@@ -43,7 +43,7 @@ class AttrTypeBytecodeReader {
                     CallableT, std::function<LogicalResult(
                                    DialectBytecodeReader &, StringRef, T &)>>,
                 bool> = true>
-  static std::unique_ptr<AttrTypeBytecodeReader<T>>
+  static std::shared_ptr<AttrTypeBytecodeReader<T>>
----------------
mfrancio wrote:

If this is a requirement, maybe the bytecode parser config could become a pointer similarly to the FallbackResourceMap and avoid the use of shared pointers here?

https://github.com/llvm/llvm-project/pull/83825


More information about the Mlir-commits mailing list