[Mlir-commits] [mlir] [mlir][tosa] Rename Tosa Div op to IntDiv Op (PR #80047)
Jacques Pienaar
llvmlistbot at llvm.org
Sun Mar 3 06:02:14 PST 2024
https://github.com/jpienaar approved this pull request.
You may be able to make it non-breaking with a using statement (I mean not for the generated IR, that would need a sed of course).
> *[Reviewable](https://reviewable.io/reviews/llvm/llvm-project/80047#-:-Ns3bbkR8lyjZta9FjbD:b-v3zbf2)* status: 0 of 10 files reviewed, 2 unresolved discussions (waiting on @Tai78641)
___
*[`mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp` line 95 at r1](https://reviewable.io/reviews/llvm/llvm-project/80047#-Ns3bD4nBZLcfmbuuFTe:-Ns3bD4nBZLcfmbuuFTf:b-u2dg7n) ([raw file](https://github.com/llvm/llvm-project/blob/1513939fcbf02b1b080185e8cdc460348f8516f6/mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp#L95)):*
> ```cpp
>
> // tosa::IntDivOp
> if (isa<tosa::IntDivOp>(op) && elementTy.isa<IntegerType>())
> ```
Prefer the other form (https://mlir.llvm.org/deprecation/)
___
*[`mlir/lib/Dialect/Tosa/IR/TosaOps.cpp` line 1333 at r1](https://reviewable.io/reviews/llvm/llvm-project/80047#-Ns3bM9qBSHKS3qWSX0P:-Ns3bM9qBSHKS3qWSX0Q:b-izakcr) ([raw file](https://github.com/llvm/llvm-project/blob/1513939fcbf02b1b080185e8cdc460348f8516f6/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp#L1333)):*
> ```cpp
> NARY_SHAPE_INFER(tosa::ClampOp)
> NARY_SHAPE_INFER(tosa::ClzOp)
> NARY_SHAPE_INFER(tosa::IntDivOp)
> ```
I think these were sorted, could you keep it such?
<!-- Sent from Reviewable.io -->
https://github.com/llvm/llvm-project/pull/80047
More information about the Mlir-commits
mailing list