[Mlir-commits] [mlir] [mlir][arith] adding comparison regression tests (PR #96974)

Andrzej WarzyƄski llvmlistbot at llvm.org
Sun Jun 30 09:29:13 PDT 2024


banach-space wrote:

Thanks! Could you try to structure this similarly that what you did for https://github.com/llvm/llvm-project/pull/96973/? Similar comment re variable names (prefer underscores to hyphens) and re where to place `CHECK` lines (near the corresponding `vector.print`).

It might be easier to finish #96973 and #96975 first, and then just replicate the style that we establish there.

https://github.com/llvm/llvm-project/pull/96974


More information about the Mlir-commits mailing list