[Mlir-commits] [mlir] mlir/Presburger: strip dependency on MLIRSupport (PR #96517)

Nikita Popov llvmlistbot at llvm.org
Sat Jun 29 00:36:07 PDT 2024


================
@@ -1946,9 +1944,8 @@ void IntegerRelation::fourierMotzkinEliminate(unsigned pos, bool darkShadow,
   for (unsigned r = 0, e = getNumEqualities(); r < e; r++) {
     if (atEq(r, pos) != 0) {
       // Use Gaussian elimination here (since we have an equality).
-      LogicalResult ret = gaussianEliminateVar(pos);
-      (void)ret;
-      assert(succeeded(ret) && "Gaussian elimination guaranteed to succeed");
+      bool ret = gaussianEliminateVar(pos);
----------------
nikic wrote:

You still need the `(void) ret` here, or `[[maybe_unused]]`, otherwise it will warn in release builds.

https://github.com/llvm/llvm-project/pull/96517


More information about the Mlir-commits mailing list