srcarroll wrote: > LGTM thanks for the review. i need to resolve conflicts and then i'll wait for @ftynse 's approval since he requested a bunch of non-trivial changes i want to make i addressed. https://github.com/llvm/llvm-project/pull/94391