[Mlir-commits] [mlir] [MLIR][Linalg] Add pass to convert linalg.generic back to named ops (PR #95656)

[Andrzej Warzyński]

https://github.com/banach-space commented:

I've finally managed to scan the whole thing. Overall LG, thanks! And thanks again for the contribution!

One thing that's still missing - some negative tests. I've made a few specific suggestions inline. You could also add one for e.g. `linalg.matvec` and mark it as TODO :) 

I've also left a couple of more small suggestion inline, but nothing major.

Also, looks like most files in "mlir/test/Dialect/Linalg" use hyphen (`-`) rather than underscore in filenames (`_`). For consistency:
* "transform-op-specialize_matmul.mlir" -> "transform-op-specialize-matmul.mlir"

Same suggestion for "transform-op-specialize_elemwise_binary.mlir" and "transform-op-specialize_elemwise_unary.mlir" (the only other 2 files with inconsistent naming)

https://github.com/llvm/llvm-project/pull/95656