[Mlir-commits] [mlir] DLTI: Restricting value type to StringAttr in a target device spec (PR #96706)

[Niranjan Hasabnis]

nhasabni wrote:

> > With the current flexibility of supporting any type of value, we will need to offer type-specific APIs to fetch a value (e.g., getDevicePropertyValueAsInt for integer type, getDevicePropertyValueAsFloat for float type, etc.) A single type of value will eliminate this need.
> 
> Return an `Attribute` also eliminates this need though.

Hmm, agree. @rengolin any thoughts?

https://github.com/llvm/llvm-project/pull/96706