[Mlir-commits] [mlir] [mlir:nvgpu] Rename `mbarrier.test.wait` to `mbarrier.test`. (PR #96505)

Chris Jones llvmlistbot at llvm.org
Tue Jun 25 02:19:24 PDT 2024


chr1sj0nes wrote:

I guess I am misunderstanding the purpose of the `nvgpu` dialect. I thought the `nvvm` dialect maps 1:1 with PTX but, as `nvgpu` is slightly higher level, we are not bound by PTX naming here. And in this case, I think the PTX op is very poorly named.

However, if we are going for consistency with PTX, should it not be named `mbarrier.test_wait`? I guess that is an identical discussion to https://github.com/llvm/llvm-project/pull/96503.

https://github.com/llvm/llvm-project/pull/96505


More information about the Mlir-commits mailing list