[Mlir-commits] [mlir] [MLIR] Fix LocationSnapshot: Use provided flags (PR #96535)

[Mehdi Amini]

================
@@ -140,7 +140,7 @@ struct LocationSnapshotPass
 
   void runOnOperation() override {
     Operation *op = getOperation();
-    if (failed(generateLocationsFromIR(fileName, op, OpPrintingFlags(), tag)))
+    if (failed(generateLocationsFromIR(fileName, op, flags, tag)))
----------------
joker-eph wrote:

This actually makes the pass not serializable, which I don't think is acceptable. Can we split the OpPrintingFlag option into "proper" options (strings and boolean) and construct the OpPrintingFlag on the fly?

https://github.com/llvm/llvm-project/pull/96535