[Mlir-commits] [mlir] [mlir][Conversion] `FuncToLLVM`: Simplify bare-pointer handling (PR #96393)

[Markus Böck]

zero9178 wrote:

> That's right, this implementation would have been feasible back then. My best guess is that the author was confused about `addArgumentMaterialization` and did not know that the given `ValueRange` is always a list of bbargs that belong to a newly added block.
> 
> I'm thinking of adding a different `MaterializationCallbackFn` type for argument materializations to make that clear:
> ```c++
> using ArgumentMaterializationCallbackFn = std::function<std::optional<Value>(
>     OpBuilder &, Type, BlockArgListType, Location)>;
> ```
> 
> But that could be a larger change and I'd rather do that in a separate PR.
> 

That'd be great! 

https://github.com/llvm/llvm-project/pull/96393