[Mlir-commits] [mlir] [mlir][vector] Always print the in_bounds attribute (PR #96031)

Mehdi Amini llvmlistbot at llvm.org
Sat Jun 22 01:54:20 PDT 2024


joker-eph wrote:

> This makes testing certain behaviours impossible (i.e. to make sure that the attribute is correctly preserved/transformed
by patterns that modify it).

I didn't quite get this part?

> Separately, it's not clear whether the absence of the in_bounds attribute in the printed IR is meant to mean that: [...]

This is a design problem: optional attributes shouldn't mean the same thing as a "default valued" one. Here a possible fix to remove the ambiguity could also be to make it non-optional (but default valued).


https://github.com/llvm/llvm-project/pull/96031


More information about the Mlir-commits mailing list