[Mlir-commits] [mlir] [mlir][vector] Refactor vector-transfer-flatten.mlir (nfc) (3/n) (PR #95745)

[Andrzej Warzyński]

================
@@ -131,10 +131,42 @@ func.func @transfer_read_dims_mismatch_non_contiguous_non_zero_indices(
 
 // -----
 
+/// The leading dynamic shapes don't affect whether this example is flattenable
+/// or not as those dynamic shapes are not candidates for flattening anyway.
+
+func.func @transfer_read_leading_dynamic_dims(
+    %arg : memref<?x?x8x4xi8, strided<[?, 32, 4, 1], offset: ?>>,
+    %idx_1 : index,
----------------
banach-space wrote:

Thanks for pointing this out! In fact, ATM  there are
*  4 instances of `idx1`, and 
* 12 instances of `idx_1` 

in this file. Let me make sure that we are indeed consistent, but I'll use `idx_1` rather than `idx1` - the former is already more common :)

Great work noticing this 😅 🙏🏻 

https://github.com/llvm/llvm-project/pull/95745