[Mlir-commits] [mlir] [mlir][Transforms] Dialect conversion: Simplify handling of dropped arguments (PR #96207)

[Markus Böck]

================
@@ -330,34 +340,37 @@ class TypeConverter {
 
   /// Register a materialization function, which must be convertible to the
   /// following form:
----------------
zero9178 wrote:

This introduction reads as if its talking about a specific materialization but this signature is used for all of them right? I think this might be worth changing to something like "All the below materializations require function objects of the following type: ".
Given the signature takes a `ValueRange` this would also serve as a hint that an argument materialization may be called with multiple block arguments. 

https://github.com/llvm/llvm-project/pull/96207