[Mlir-commits] [mlir] [mlir] load dialects for non-namespaced attrs (PR #96242)

Anton Korobeynikov llvmlistbot at llvm.org
Thu Jun 20 18:20:24 PDT 2024


asl wrote:

> Edit: it also seems that all the commits Jeremy has with the google e-mail are co-authored by the noreply e-mail. If GitHub fails to link the commit to his account when changing the author, maybe try this!

Yeah, likely. The checker 

> @asl @tstellar ; this check seems bogus?
> 
> > ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-emails-on-github-should-we-do-something-about-it) for more information.

The checker just do `git log -1` and the output is in the action log. Here we're having:
```
commit ef01d96886bbb69bd86b675bd4effb1dec142583
Author: Jeremy Kun <j2kun at users.noreply.github.com>
Date:   Fri Jun 7 21:27:57 2024 -0700

    [mlir] load dialects for non-namespaced attrs
    
    The mlir-translate tool calls into the parser without loading registered
    dependent dialects, and the parser only loads attributes if the
    fully-namespaced attribute is present in the textual IR. This causes
    parsing to break when an op has an attribute that prints/parses
    without the namespaced attribute.
```

So, clearly private address.

https://github.com/llvm/llvm-project/pull/96242


More information about the Mlir-commits mailing list