[Mlir-commits] [mlir] [mlir][vector] Always print the in_bounds attribute (PR #96031)

[Andrzej Warzyński]

banach-space wrote:

> I think it would be better if we make the attribute mandatory with default values set to false.

> we talked about removing this attribute in favor of simplifying this op and use masking instead

I am afraid that both would be more intrusive with various implications. I can look into this later, but for now I just want to be able to add more tests in https://github.com/llvm/llvm-project/pull/96033 :) I feel that this change is already an improvement 😅 

> I would still avoid printing the default attribute to make the op less verbose since this is ops are already hard to read.

Right, but we need to agree what the default should be :) IIUC, right now the default is "no attribute", which is treated as "in bounds".

https://github.com/llvm/llvm-project/pull/96031