[Mlir-commits] [mlir] [mlir][vector] Fix FlattenGather for scalable vectors (PR #96074)

Benjamin Maxwell llvmlistbot at llvm.org
Wed Jun 19 07:28:33 PDT 2024


================
@@ -211,6 +211,11 @@ Value createReadOrMaskedRead(OpBuilder &builder, Location loc, Value source,
 ///      static sizes in `shape`.
 LogicalResult isValidMaskedInputVector(ArrayRef<int64_t> shape,
                                        ArrayRef<int64_t> inputVectorSizes);
+
+/// Returns true if the leading dim(s) of `type` are fixed and the trailing dim
+/// is scalable.
+bool isTrailingDimScalable(VectorType type);
----------------
MacDue wrote:

I think it'd be a little clearer to add 'only':
```suggestion
bool isOnlyTrailingDimScalable(VectorType type);
```

https://github.com/llvm/llvm-project/pull/96074


More information about the Mlir-commits mailing list