[Mlir-commits] [mlir] [MLIR][Linalg] Add pass to convert linalg.generic back to named ops (PR #95656)

Andrzej WarzyƄski llvmlistbot at llvm.org
Wed Jun 19 01:41:18 PDT 2024


================

----------------
banach-space wrote:

Let's avoid "random" :) In particular, how are we meant to know that this works for all Ops if we are only testing a random subset? if you feel that a sub-set of Linalg Ops would be sufficient, then please document through comments and/or test function names.

Also, would you mind splitting "unary",  "binary" and "mix" cases with big bold comments? Provided that that's how you want to categorise these tests.

Btw, same comment for the other test file.

https://github.com/llvm/llvm-project/pull/95656


More information about the Mlir-commits mailing list