[Mlir-commits] [flang] [mlir] [OpenMP][LLVM] Clone `omp.private` op in the parent module (PR #96024)

[Kareem Ergawy]

================

----------------
ergawy wrote:

Not sure if this going to be easy since:
* `OpenMPDialectLLVMIRTranslationInterface` does not have any unit testing components at the moment,
* the implementation is mostly `static` functions that encapsulates all the internal details so we don't have fine-grained control over the steps taken to convert an op,
* even if we had, I think this particular change would still be difficult to test in a unit test since cloning the op is a transient change that happens to the MLIR module: the clone is discarded once the need for it is gone.

Let me know if you disagree or have any suggestions. Always happy to add more testing.

https://github.com/llvm/llvm-project/pull/96024