[Mlir-commits] [mlir] Reimplementing target description concept using DLTI attribute (PR #92138)

Mehdi Amini llvmlistbot at llvm.org
Mon Jun 17 06:06:08 PDT 2024


================
@@ -293,6 +293,28 @@ mlir::detail::getDefaultStackAlignment(DataLayoutEntryInterface entry) {
   return value.getValue().getZExtValue();
 }
 
+// Returns the max vector op width if specified in the given entry. If the entry
+// is empty (meaning the spec is missing), returns std::nullopt.
+std::optional<int64_t>
+mlir::detail::getMaxVectorOpWidth(DataLayoutEntryInterface entry) {
+  if (entry == DataLayoutEntryInterface())
----------------
joker-eph wrote:

```suggestion
  if (!entry)
```

But is this check useful?

https://github.com/llvm/llvm-project/pull/92138


More information about the Mlir-commits mailing list