[Mlir-commits] [mlir] Reimplementing target description concept using DLTI attribute (PR #92138)

[Renato Golin]

================
@@ -194,6 +194,162 @@ def DataLayoutSpecInterface : AttrInterface<"DataLayoutSpecInterface"> {
   }];
 }
 
+def TargetDeviceDescSpecInterface : AttrInterface<"TargetDeviceDescSpecInterface"> {
+  let cppNamespace = "::mlir";
+
+  let description = [{
+    Attribute interface describing a target device description specification.
+
+    A target device description specification is a list of device properties (key)
+    and their values for a specific device. The device is identified using "device_id"
+    (as a key and ui32 value) and "device_type" key which must have a string value.
+    Both "device_id" and "device_type" are mandatory keys. As an example, L1 cache
+    size could be a device property, and its value would be a device specific size.
+
+    A target device description specification is attached to a module as a module level
+    attribute.
----------------
rengolin wrote:

@joker-eph This is the last unaddressed comment. Does my answer help with your question? I think we can solve this later, either relaxing the constraint (as you propose), or creating a hook back to the module's attribute (as I propose). I'd like to get this merged, so we can multi-task the following changes that all depend on this one.

https://github.com/llvm/llvm-project/pull/92138