[Mlir-commits] [mlir] [mlir][Target] Improve ROCDL gpu serialization API (PR #95456)

[Fabian Mora]

fabianmcg wrote:

@krzysz00 I'm still not convinced on using tablegen for the AMD GCN lib enum as there are no consumers for it as an attribute, and we generally keep things minimal and internal unless there's a use case, and right now there are none. Also, I would argue that the enum in question is completely internal to the compilation process and it shouldn't be exposed.
However, I switched the class to an `enum class`, and by using https://www.llvm.org/doxygen/BitmaskEnum_8h.html I removed many of the methods, reducing code duplication.

With respect to CMake and `DEFAULT_ROCM_PATH`, right now using `FindHip` is not robust enough, as the module still lives inside `/opt/rocm` and not CMake. Hence, I'm arguing that it's the responsibility of the builder/maintainer to specify `DEFAULT_ROCM_PATH` when building LLVM, otherwise we will encounter fragile builds and issues with windows.

https://github.com/llvm/llvm-project/pull/95456