[Mlir-commits] [mlir] Introduce new Unroll And Jam loop transform for SCF/Affine loops (PR #94142)

Oleksandr Alex Zinenko llvmlistbot at llvm.org
Fri Jun 14 08:41:14 PDT 2024


================
@@ -591,6 +591,7 @@ ForOp::replaceWithAdditionalYields(RewriterBase &rewriter,
   // Replace the old loop.
   rewriter.replaceOp(getOperation(),
                      newLoop->getResults().take_front(getNumResults()));
+  newLoop->setAttrs(getOperation()->getAttrs());
----------------
ftynse wrote:

Is this relevant for this change? Looks like an omission in the original implementation of this operation, but we need to be careful and avoid carrying over inherent attributes, so it would need a separate test.

https://github.com/llvm/llvm-project/pull/94142


More information about the Mlir-commits mailing list