[Mlir-commits] [mlir] [mlir][vector] Add tests for `TransferWritePermutationLowering` (PR #95529)
Hugo Trachino
llvmlistbot at llvm.org
Fri Jun 14 07:41:53 PDT 2024
================
@@ -1,14 +1,81 @@
// RUN: mlir-opt %s --transform-interpreter --split-input-file | FileCheck %s
///----------------------------------------------------------------------------------------
-/// vector.transfer_write
+/// vector.transfer_write -> vector.transpose + vector.transfer_read
///----------------------------------------------------------------------------------------
-/// Input:
-/// * vector.transfer_write op with a map which _is not_ the permutation of a
-/// minor identity
+/// Input:
+/// * vector.transfer_write op with a permutation that under a transpose
+/// _would be_ a permutation of a minor identity
----------------
nujaa wrote:
I find this confusing. A transpose of a permutation of a minor identity is another permutation of a minor identity. `TransferWritePermutationLowering` hoists transpositions out of a permutation map. So I'd say
```suggestion
/// * vector.transfer_write op with a permutation map outputting
/// a permutation of a minor identity.
```
https://github.com/llvm/llvm-project/pull/95529
More information about the Mlir-commits
mailing list